Skip to content

Improve StrSplit returnType #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 1.12.x
Choose a base branch
from
Draft

Improve StrSplit returnType #3999

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented May 18, 2025 •
edited
Loading

Hi @herndlm

I saw you worked multiple times on this extension with

So you might want to review this.

I still need to update the LegacyNodeScopeResolverTest.

@ondrejmirtes Do you want me to fix the LegacyNodeScopeResolverTest as if, or would it be ok to migrate them inside the new NodeScopeResolverTest instead ?

@VincentLanglet VincentLanglet mentioned this pull request May 18, 2025
Open
@VincentLanglet
Copy link
Contributor Author

If it's ok, I opened #4000 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VincentLanglet